New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: rearrange loggers #3987

Merged
merged 4 commits into from Jan 2, 2019

Conversation

Projects
None yet
5 participants
@overvenus
Copy link
Member

overvenus commented Dec 27, 2018

What have you changed? (mandatory)

Rearrangement log related modules and extact drainers, so we can use them in other place.

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Unit tests

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

*: rearrange loggers
Signed-off-by: Neil Shen <overvenus@gmail.com>

@Connor1996 Connor1996 added the C: Util label Dec 27, 2018

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Dec 28, 2018

PTAL @Hoverbear

@Hoverbear
Copy link
Member

Hoverbear left a comment

LGTM

@overvenus overvenus added the S: LGT1 label Dec 29, 2018

@Hoverbear Hoverbear requested a review from rleungx Dec 31, 2018

@Hoverbear

This comment has been minimized.

Copy link
Member

Hoverbear commented Dec 31, 2018

@overvenus You have a conflict. Please fix it :)

@Hijiao

Hijiao approved these changes Jan 2, 2019

Copy link
Contributor

Hijiao left a comment

LGTM

@overvenus overvenus added S: LGT2 and removed S: LGT1 labels Jan 2, 2019

@overvenus overvenus merged commit 34f57ec into tikv:master Jan 2, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:rearrange-loggers branch Jan 2, 2019

overvenus added a commit to overvenus/tikv that referenced this pull request Jan 3, 2019

*: rearrange loggers (tikv#3987)
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment