New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade `rust-rocksdb`: make it possible to upgrade from `RocksDB` to `Titan` smoothly #4002

Merged
merged 2 commits into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@DorianZheng
Copy link
Member

DorianZheng commented Jan 2, 2019

Signed-off-by: DorianZheng xingzhengde72@gmail.com

What have you changed? (mandatory)

We don't check if the directory of Titan data exists, so we can upgrade TiKV from RocksDB-based to Titan-based smoothly.

What are the type of the changes? (mandatory)

  • Improvement

How has this PR been tested? (mandatory)

1, Initiate TiKV with RocksDB at first and import some data.
2, Stop TiKV and set it to use Titan.
3, Start and check if it's still normal.

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

upgrade titan
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>

@DorianZheng DorianZheng changed the title Upgrade `rust-rocksdb`: make it possible to upgrade from `RocksDB` to `Titan` without pain Upgrade `rust-rocksdb`: make it possible to upgrade from `RocksDB` to `Titan` smoothly Jan 2, 2019

@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

@DorianZheng DorianZheng added the C: Titan label Jan 2, 2019

@DorianZheng DorianZheng merged commit 122544e into tikv:master Jan 2, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details

@DorianZheng DorianZheng deleted the DorianZheng:upgrade_titan branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment