Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: support batch grpc messages. #4043

Merged
merged 16 commits into from Jan 12, 2019

Conversation

@hicqu
Copy link
Contributor

commented Jan 9, 2019

Signed-off-by: qupeng qupeng@pingcap.com

This PR supports batch gRPC messages between TiKVs and TiDBs.

What are the type of the changes? (mandatory)

Improvement.

How has this PR been tested? (mandatory)

Unit tests and integration tests.

Does this PR affect documentation (docs) update? (mandatory)

No.

Refer to a related PR or issue link (optional)

pingcap/kvproto#294
pingcap/tidb#7821

Benchmark result if necessary (optional)

default

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu referenced this pull request Jan 9, 2019
@Connor1996

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

Please fix the conflicts

@Connor1996 Connor1996 changed the title Support batch grpc messages. server: support batch grpc messages. Jan 10, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
src/server/service/kv.rs Outdated Show resolved Hide resolved
hicqu added 2 commits Jan 10, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
src/server/service/kv.rs Outdated Show resolved Hide resolved
src/server/service/kv.rs Outdated Show resolved Hide resolved
src/server/service/kv.rs Outdated Show resolved Hide resolved
src/server/service/kv.rs Outdated Show resolved Hide resolved
src/server/service/kv.rs Show resolved Hide resolved
src/server/service/kv.rs Outdated Show resolved Hide resolved
src/server/metrics.rs Outdated Show resolved Hide resolved
@Connor1996 Connor1996 added the C: gRPC label Jan 10, 2019
@siddontang

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

can you split this into two PRs? one is for refactoring futures, one is for batch.

Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added 2 commits Jan 10, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu force-pushed the hicqu:batch-grpc-msg branch from e6ec1eb to df70181 Jan 10, 2019
src/server/metrics.rs Outdated Show resolved Hide resolved
src/server/metrics.rs Outdated Show resolved Hide resolved
@zhangjinpeng1987

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

rest LGTM
Please provide the benchmark result.

hicqu added 2 commits Jan 11, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
src/server/service/kv.rs Outdated Show resolved Hide resolved
hicqu added 3 commits Jan 11, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Copy link
Member

left a comment

LGTM

tests/integrations/server/kv_service.rs Outdated Show resolved Hide resolved
tests/integrations/server/kv_service.rs Outdated Show resolved Hide resolved
@hicqu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

/run-integration-tests

Copy link
Member

left a comment

LGTM

Copy link
Contributor

left a comment

LGTM

@hicqu hicqu merged commit 5941460 into tikv:master Jan 12, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
@hicqu hicqu deleted the hicqu:batch-grpc-msg branch Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.