Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor:cherry-pick #3774 #4075

Merged

Conversation

@AndreMouche
Copy link
Member

commented Jan 15, 2019

Signed-off-by: AndreMouche AndreMouche@126.com

What have you changed? (mandatory)

This PR cherry-pick #3774 to release-2.1:

  1. fix bug in date_format
  2. add functions day_name, day_of_month, day_of_week, day_of_year

Please NOTE that:

  • Do not assume reviewers understand the original issue

What are the type of the changes? (mandatory)

The currently defined types are listed below, please pick one of the types for this PR by removing the others:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

yes

Does this PR affect documentation (docs) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@breeswish @DorianZheng PTAL

koushiro and others added 7 commits Nov 16, 2018
Signed-off-by: AndreMouche <AndreMouche@126.com>
Signed-off-by: wuxuelian <AndreMouche@126.com>
Signed-off-by: wuxuelian <AndreMouche@126.com>
Signed-off-by: wuxuelian <AndreMouche@126.com>
Signed-off-by: wuxuelian <AndreMouche@126.com>
Signed-off-by: wuxuelian <AndreMouche@126.com>
Signed-off-by: wuxuelian <AndreMouche@126.com>
Signed-off-by: wuxuelian <AndreMouche@126.com>
@XuHuaiyu

This comment has been minimized.

Copy link

commented Jan 16, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

@AndreMouche

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

/run-integration-compatibility-test

@AndreMouche

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

/run-all-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Member

left a comment

Failed integration tests are not related to our change. @zhouqiang-cl PTAL

@huachaohuang huachaohuang merged commit 8fc3e65 into tikv:release-2.1 Jan 16, 2019
5 of 6 checks passed
5 of 6 checks passed
idc-jenkins-ci-tikv/integration-common-test Jenkins job failed
Details
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
@winkyao

This comment has been minimized.

Copy link

commented Jan 16, 2019

/run-integration-common-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 -tidb-test=pr/721

AndreMouche added a commit to AndreMouche/tikv that referenced this pull request Jan 16, 2019
* coprocessor:cherry pick tikv#3774

Signed-off-by: AndreMouche <AndreMouche@126.com>
AndreMouche added a commit that referenced this pull request Jan 16, 2019
* coprocessor:cherry pick #3774

Signed-off-by: AndreMouche <AndreMouche@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.