New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo: disable procinfo on non-Linux #4133

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@overvenus
Copy link
Member

overvenus commented Jan 27, 2019

What have you changed? (mandatory)

Fix complie error on non-Linux by disable the procinfo crate.

What are the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Manually, maybe we should test macOS build on CircleCI?

Does this PR affect documentation (docs) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

Close #4130.

Cargo: disable procinfo on non-Linux
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus added the S: WIP label Jan 27, 2019

@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

Em, can we add a CI for building TiKV in MacOS? @zhouqiang-cl

@hicqu

This comment has been minimized.

Copy link
Contributor

hicqu commented Jan 28, 2019

LGTM

@hicqu

hicqu approved these changes Jan 28, 2019

@overvenus overvenus removed the S: WIP label Jan 28, 2019

@overvenus overvenus merged commit 15355d6 into tikv:master Jan 28, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:linux-procinfo branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment