Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade to Rust 2018 #4138
This upgrades the tikv package and all of the component packages to 2018.
It does not yet upgrade any of the fuzzing code to 2018, mostly because I didn't want to go through the long process of revalidating the fuzzers. Somebody else can make those changes while they are working on the fuzzers, if they feel like it's important.
The commits are all pretty straightforward at this point.
After this there is still work that can be done to bring tikv up to date with 2018 idioms. I'll file separate bugs on that.
@hicqu CI failed
Re my previous comment about CI being affecting by this toolchain's entropy bug, that is incorrect. @zhouqiang-cl has upgraded the CI machines to a new kernel that is not affected. The CD machines though are affected still.
So I think we can move forward with this. I don't foresee reverting the toolchain at this point.