New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure criterion from command line arguments #4169

Merged
merged 4 commits into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@brson
Copy link
Contributor

brson commented Jan 31, 2019

What have you changed? (mandatory)

This changes the raftstore and coprocessor_executors benchmarks to parse criterion's command line arguments. This allows it to interpret --save-baseline, so that it works with critcmp, per #4037.

The criterion upgrade is also per #4037 - the latest version of critcmp seems to need the version specified here.

What are the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Running the benchmarks with --save-baseline and then running critcmp.

Does this PR affect documentation (docs) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

Fixes #4037

brson added some commits Jan 8, 2019

*: upgrade criterion to exactly 0.2.5
Cargo.lock had this as 0.2.4, which does not seem to work with
the current critcmp tool. This pins criterion to exactly
the version critcmp is known to work with.

Signed-off-by: Brian Anderson <andersrb@gmail.com>
benches: Configure criterion from command line args
This will let them interpret --save-baseline correctly.

Signed-off-by: Brian Anderson <andersrb@gmail.com>
@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 31, 2019

flaky test_server_half_split_region failed

/rebuild

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 31, 2019

test_server_half_split_region failed again

/rebuild

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Feb 1, 2019

test_server_half_split_region failed again
@Connor1996

@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

@Connor1996

This comment has been minimized.

Copy link
Member

Connor1996 commented Feb 1, 2019

@siddontang The fix was merged in master just now. Once update branch, it would not fail again.

@Connor1996
Copy link
Member

Connor1996 left a comment

LGTM

@siddontang siddontang merged commit 08d5255 into tikv:master Feb 1, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment