Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics for key exceed bound #4255

Merged

Conversation

@zhangjinpeng1987
Copy link
Member

commented Feb 22, 2019

Signed-off-by: zhangjinpeng1987 zhangjinpeng@pingcap.com

What are the type of the changes? (mandatory)

The currently defined types are listed below, please pick one of the types for this PR by removing the others:

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

No

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

zhangjinpeng1987 added some commits Feb 22, 2019

add metrics for key exceed bound
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
merge master
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
@@ -221,4 +221,10 @@ lazy_static! {
&["type"],
exponential_buckets(0.001, 1.59, 20).unwrap() // max 10s
).unwrap();

pub static ref KEY_NOT_IN_REGION: IntCounter = register_int_counter!(

This comment has been minimized.

Copy link
@siddontang

siddontang Feb 23, 2019

Contributor

do we need to add a label so we can locate where it raises?

This comment has been minimized.

Copy link
@breeswish

breeswish Feb 23, 2019

Member

Maybe not a good idea. Constant labels are preferred. Dynamic labels are likely to cause memory never being released because these metric instance need to be kept permanently.

@siddontang
Copy link
Contributor

left a comment

LGTM

@zhangjinpeng1987

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

/run-all-tests

@zhangjinpeng1987 zhangjinpeng1987 merged commit f581a95 into tikv:master Feb 25, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@zhangjinpeng1987 zhangjinpeng1987 deleted the zhangjinpeng1987:key-exceed-bound-metrics branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.