add metrics for key exceed bound #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
siddontang
reviewed
Feb 23, 2019
| @@ -221,4 +221,10 @@ lazy_static! { | |||
| &["type"], | |||
| exponential_buckets(0.001, 1.59, 20).unwrap() // max 10s | |||
| ).unwrap(); | |||
|
|
|||
| pub static ref KEY_NOT_IN_REGION: IntCounter = register_int_counter!( | |||
There was a problem hiding this comment.
do we need to add a label so we can locate where it raises?
There was a problem hiding this comment.
Maybe not a good idea. Constant labels are preferred. Dynamic labels are likely to cause memory never being released because these metric instance need to be kept permanently.
breezewish
approved these changes
Feb 23, 2019
|
/run-all-tests |
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangjinpeng1987 zhangjinpeng@pingcap.com
What are the type of the changes? (mandatory)
The currently defined types are listed below, please pick one of the types for this PR by removing the others:
How has this PR been tested? (mandatory)
No
Does this PR affect documentation (docs) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No