Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add Communication section in readme #4285

Merged
merged 5 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@dcalvin
Copy link
Member

dcalvin commented Feb 26, 2019

Signed-off-by: Calvin Weng wenghao@pingcap.com

What have you changed? (mandatory)

  • Added Communication section in readme as suggested by Siddon

What are the type of the changes? (mandatory)

  • Improvement
add Communication section in readme
Signed-off-by: Calvin Weng <wenghao@pingcap.com>

@dcalvin dcalvin added the C: Doc label Feb 26, 2019

@dcalvin dcalvin requested review from Hoverbear , brson and siddontang Feb 26, 2019

add square brackets for email link.
Signed-off-by: Calvin Weng <wenghao@pingcap.com>

@dcalvin dcalvin changed the title add Communication section in readme readme: add Communication section in readme Feb 26, 2019

@dcalvin

This comment has been minimized.

Copy link
Member Author

dcalvin commented Feb 26, 2019

Anything else to add?

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md
address comments from Ana
Signed-off-by: Calvin Weng <wenghao@pingcap.com>
@brson

This comment has been minimized.

Copy link
Contributor

brson commented Mar 4, 2019

Awesome awesome stuff @dcalvin 🥇 LGTM

@brson

brson approved these changes Mar 4, 2019

@Hoverbear Hoverbear merged commit f95302e into tikv:master Mar 4, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.