Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `extern crate` statements from the repo #4297

Merged
merged 3 commits into from Mar 4, 2019

Conversation

Projects
None yet
6 participants
@wujunze
Copy link
Contributor

wujunze commented Feb 28, 2019

What have you changed? (mandatory)

. Optimize Rust code
. makes some automated changes to be more idiomatic, in particular post-2018 edition

What are the type of the changes? (mandatory)

Optimize Rust code

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Yes

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Refer to a related PR or issue link (optional)

#4196

about issue #4196

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Feb 28, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@wujunze

This comment has been minimized.

Copy link
Contributor Author

wujunze commented Mar 1, 2019

@siddontang Please help me review this PR Thanks

@rleungx

This comment has been minimized.

Copy link
Member

rleungx commented Mar 1, 2019

@wujunze Thanks for your contribution! Please sign-off the DCO.

@rleungx

This comment has been minimized.

Copy link
Member

rleungx commented Mar 1, 2019

Oh, I found #4300 almost did this job.

@rleungx rleungx self-assigned this Mar 1, 2019

@zhangjinpeng1987
Copy link
Member

zhangjinpeng1987 left a comment

LGTM

@zhangjinpeng1987

This comment has been minimized.

Copy link
Member

zhangjinpeng1987 commented Mar 2, 2019

@rleungx I think it doesn't matter, we can merge this first.

@wujunze

This comment has been minimized.

Copy link
Contributor Author

wujunze commented Mar 2, 2019

@wujunze Thanks for your contribution! Please sign-off the DCO.

Thanks for your review I sign-off the DCO.

@wujunze

This comment has been minimized.

Copy link
Contributor Author

wujunze commented Mar 2, 2019

@rleungx I think it doesn't matter, we can merge this first.

Thanks for your review !

Remove `extern crate` statements from the repo
Signed-off-by: Panda <itwujunze@163.com>
@wujunze

This comment has been minimized.

Copy link
Contributor Author

wujunze commented Mar 2, 2019

Please help me review @zhangjinpeng1987 @rleungx
Thanks

@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

PTAL @brson

@zhangjinpeng1987
Copy link
Member

zhangjinpeng1987 left a comment

LGTM

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Mar 4, 2019

LGTM Thanks @wujunze !

@brson brson referenced this pull request Mar 4, 2019

Merged

Miscellaneous tidying up #4300

@brson brson merged commit 43f5b10 into tikv:master Mar 4, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.