Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny typo #4305

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@zhangjinpeng1987
Copy link
Member

zhangjinpeng1987 commented Mar 3, 2019

Signed-off-by: zhangjinpeng1987 zhangjinpeng@pingcap.com

What have you changed? (mandatory)

Fix some typo errors.

What are the type of the changes? (mandatory)

The currently defined types are listed below, please pick one of the types for this PR by removing the others:

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

No

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

tiny typo
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
@MyonKeminta
Copy link
Contributor

MyonKeminta left a comment

mostly LGTM

@@ -97,7 +97,7 @@ fn check_system_config(config: &TiKvConfig) {
);
}

// check rocksdb data dir
// check RocksDB data dir

This comment has been minimized.

@MyonKeminta

MyonKeminta Mar 3, 2019

Contributor

check -> Check?

address comments
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

@zhangjinpeng1987 zhangjinpeng1987 merged commit aa508ef into tikv:master Mar 4, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@zhangjinpeng1987 zhangjinpeng1987 deleted the zhangjinpeng1987:tiny-typo branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.