Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore/store: unified log format #4307

Merged
merged 5 commits into from Mar 6, 2019

Conversation

Projects
None yet
5 participants
@Connor1996
Copy link
Member

Connor1996 commented Mar 4, 2019

What have you changed? (mandatory)

Addressing the RFC Unified Log Format for raftstore/store module.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

No need

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

@Connor1996 Connor1996 added the C: Raft label Mar 4, 2019

@Connor1996 Connor1996 requested review from BusyJay and huachaohuang Mar 4, 2019

change log
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 force-pushed the Connor1996:store-log branch from 29a3e2d to 08730ed Mar 4, 2019

@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

@zhangjinpeng1987
Copy link
Member

zhangjinpeng1987 left a comment

LGTM

tiny change
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 dismissed stale reviews from zhangjinpeng1987 and siddontang via eb84d90 Mar 4, 2019

@Connor1996 Connor1996 force-pushed the Connor1996:store-log branch from da918aa to eb84d90 Mar 4, 2019

@Connor1996 Connor1996 force-pushed the Connor1996:store-log branch from b36c0f3 to d9719a9 Mar 5, 2019

@Connor1996

This comment has been minimized.

Copy link
Member Author

Connor1996 commented Mar 5, 2019

PTAL again

@zhangjinpeng1987
Copy link
Member

zhangjinpeng1987 left a comment

LGTM

Show resolved Hide resolved src/raftstore/store/peer.rs Outdated
Show resolved Hide resolved src/raftstore/store/peer.rs Outdated
address comment
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@nolouch

nolouch approved these changes Mar 6, 2019

@MyonKeminta
Copy link
Contributor

MyonKeminta left a comment

LGTM

@Connor1996 Connor1996 merged commit 7aadfe9 into tikv:master Mar 6, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@Connor1996 Connor1996 deleted the Connor1996:store-log branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.