Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: check sse4.2 for tikv targets #4314

Merged
merged 4 commits into from Mar 5, 2019

Conversation

Projects
None yet
6 participants
@overvenus
Copy link
Member

overvenus commented Mar 5, 2019

What have you changed? (mandatory)

Add a script to checks whether tikv-server enables sse4.2.

What are the type of the changes? (mandatory)

  • Misc (other changes)

How has this PR been tested? (mandatory)

CI

Does this PR affect documentation (docs) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No.

overvenus added some commits Mar 4, 2019

Makefile: print cargo build commands
Signed-off-by: Neil Shen <overvenus@gmail.com>
Makefile: check sse4.2 for tikv targets
Signed-off-by: Neil Shen <overvenus@gmail.com>

@rleungx rleungx added the C: Build label Mar 5, 2019

@zhangjinpeng1987
Copy link
Member

zhangjinpeng1987 left a comment

LGTM

if [[ ! $fast_crc32 ]]; then
echo "error: $dirfile does not contain rocksdb::crc32c::Fast_CRC32 function"
errors=1
continue

This comment has been minimized.

@Connor1996

Connor1996 Mar 5, 2019

Member

why not break here

This comment has been minimized.

@overvenus

overvenus Mar 5, 2019

Author Member

Because we want to check other files

This comment has been minimized.

@Connor1996

Connor1996 Mar 5, 2019

Member

But seems once errors=1, checking other files doesn't matter the result.

This comment has been minimized.

@overvenus

overvenus Mar 5, 2019

Author Member

Yes, I mean we may want to know how many files are not using sse4.2.

@Connor1996
Copy link
Member

Connor1996 left a comment

LGTM

@BusyJay

This comment has been minimized.

Copy link
Contributor

BusyJay commented Mar 5, 2019

/run-integration-tests

@breeswish

This comment has been minimized.

Copy link
Member

breeswish commented Mar 5, 2019

Should we also forbid new instruction sets like AVX and AVX2?

Additionally I think it might not be very good to put this script in TiKV repo because it is not a really TiKV stuff 🤣

@overvenus

This comment has been minimized.

Copy link
Member Author

overvenus commented Mar 5, 2019

Should we also forbid new instruction sets like AVX and AVX2?

This script only ensures tikv has sse4.2 support, does not care about other instruction sets.

Additionally I think it might not be very good to put this script in TiKV repo because it is not a really TiKV stuff

Yes, so I place it under the etc folder and write comments for CI use only.

@overvenus overvenus merged commit 0c2d142 into tikv:master Mar 5, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:portabl-sse branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.