Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce VectorLike #4320

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@breeswish
Copy link
Member

breeswish commented Mar 6, 2019

Signed-off-by: Breezewish breezewish@pingcap.com

What have you changed? (mandatory)

This PR adds VectorLike, which is an enum for vector and scalar that supports index access. When underlying is a scalar, any index access will return the same value. When underlying is a vector, index access will return the corresponding element of the vector. Simply speaking, this provides a unified type for "vector like" types which will act like a vector.

This is extracted from #3898

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)
Introduce vector_like
Signed-off-by: Breezewish <breezewish@pingcap.com>

@breeswish breeswish referenced this pull request Mar 6, 2019

Merged

Implements AsMySQLBool #4321

1 of 1 task complete

@breeswish breeswish added the C: Copr label Mar 6, 2019

@AndreMouche
Copy link
Member

AndreMouche left a comment

LGTM

@rleungx
Copy link
Member

rleungx left a comment

The rest LGTM.

@@ -13,6 +13,7 @@

mod scalar;
mod vector;
mod vector_like;

This comment has been minimized.

@rleungx

rleungx Mar 7, 2019

Member

The naming looks wired.

breeswish added some commits Mar 7, 2019

@rleungx

rleungx approved these changes Mar 7, 2019

@breeswish

This comment has been minimized.

Copy link
Member Author

breeswish commented Mar 7, 2019

/rebuild

@breeswish breeswish merged commit 206209f into tikv:master Mar 7, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@breeswish breeswish deleted the breeswish:____batch_extract/t3/1 branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.