Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary Copy trait of Tz and EvalConfig #4380

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@iosmanthus
Copy link
Contributor

commented Mar 15, 2019

What have you changed? (mandatory)

Fix issue: #4341
plenty of functions read Tz and use it to construct a correct Time by copying them so does EvalConfig. No need to copy, just take ownership or use references. But using reference is hard now...
There are too many signatures to modify and it is likely to break lots of API.

What are the type of changes? (mandatory)

  • Improvement (a change which is an improvement to an existing feature)
    reduce the number of Tz copy in the stack.

How has this PR been tested? (mandatory)

make test already.

remove Copy trait of Tz/EvalConfig
- remove Copy trait of Tz/EvalConfig
- accept & for Tz in related functions

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@breeswish
Copy link
Member

left a comment

Nice job!

@breeswish

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/run-integration-tests

@rleungx
Copy link
Member

left a comment

LGTM.

@breeswish breeswish merged commit 39e17b5 into tikv:master Mar 15, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@breeswish breeswish referenced this pull request Mar 18, 2019

Closed

Accept & for Tz #4341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.