Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max column check when building vectorized expression #4481

Merged
merged 26 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@breeswish
Copy link
Member

breeswish commented Apr 4, 2019

What have you changed? (mandatory)

When giving column offset is invalid, the evaluation will panic. So this adds checks to the max column when building the RPN expression, so that invalid expressions will be detected early and return correct error instead of panic.

Extracted from #3898

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

breeswish added some commits Mar 26, 2019

Extract execution summary support
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge master
Signed-off-by: Breezewish <breezewish@pingcap.com>
Revert an incorrect code rearrangement
Signed-off-by: Breezewish <breezewish@pingcap.com>
Fix space issues
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge branch '____batch_extract/exec_summary' of github.com:breeswish…
…/tikv into ____batch_extract/exec_summary
Rename variables to make it more clear
Signed-off-by: Breezewish <breezewish@pingcap.com>
Move scanner out of executor
Signed-off-by: Breezewish <breezewish@pingcap.com>
Move scan executors
Signed-off-by: Breezewish <breezewish@pingcap.com>
Add some new casts for LazyBatchColumn(Vec)
Signed-off-by: Breezewish <breezewish@pingcap.com>
Add max column checks
Signed-off-by: Breezewish <breezewish@pingcap.com>

@breeswish breeswish referenced this pull request Apr 4, 2019

Merged

Change Evaluable from Option<T> to T #4482

1 of 1 task complete

breeswish added some commits Apr 8, 2019

Move executors into the same directory
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge remote-tracking branch 'origin/master' into ___batch_extract/t4/5
Signed-off-by: Breezewish <breezewish@pingcap.com>
Remove unrelated functions
Signed-off-by: Breezewish <breezewish@pingcap.com>
@AndreMouche
Copy link
Member

AndreMouche left a comment

Rest LGTM

Verify that max columns check works
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breeswish

This comment has been minimized.

Copy link
Member Author

breeswish commented Apr 11, 2019

/rebuild

@breeswish breeswish merged commit 57b6302 into tikv:master Apr 11, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@breeswish breeswish deleted the breeswish:___batch_extract/t4/5 branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.