New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no need to use region peers #4484
Conversation
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
/release |
/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
1 similar comment
/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
em, don't we need this in master, only in release? |
no need in master cause master branch is not implemented in that way due to threaded raftstore |
/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
PTAL @BusyJay |
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
/release |
/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about split the the method into two? So that one can use only immutable reference for regular checks the other use mutable to actually mutate the states.
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
/run-all-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
1 similar comment
/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix performance issue