Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need to use region peers #4484

Merged
merged 4 commits into from Apr 7, 2019
Merged

Conversation

Connor1996
Copy link
Member

fix performance issue

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@Connor1996
Copy link
Member Author

/release

@sre-bot
Copy link
Contributor

sre-bot commented Apr 4, 2019

@Connor1996
Copy link
Member Author

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

1 similar comment
@Connor1996
Copy link
Member Author

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@siddontang
Copy link
Contributor

em, don't we need this in master, only in release?

@Connor1996
Copy link
Member Author

no need in master cause master branch is not implemented in that way due to threaded raftstore

@Connor1996
Copy link
Member Author

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@Connor1996
Copy link
Member Author

PTAL @BusyJay

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

/release

@Connor1996
Copy link
Member Author

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@sre-bot
Copy link
Contributor

sre-bot commented Apr 5, 2019

src/raftstore/store/peer.rs Outdated Show resolved Hide resolved
@AndreMouche AndreMouche added the sig/raft Component: Raft, RaftStore, etc. label Apr 6, 2019
@hicqu
Copy link
Contributor

hicqu commented Apr 6, 2019

LGTM.

hicqu
hicqu previously approved these changes Apr 6, 2019
src/raftstore/store/peer.rs Outdated Show resolved Hide resolved
@kennytm kennytm added status/LGT1 Status: PR - There is already 1 approval type/cherry-pick Type: PR - Cherry pick and removed type/cherry-pick Type: PR - Cherry pick labels Apr 6, 2019
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about split the the method into two? So that one can use only immutable reference for regular checks the other use mutable to actually mutate the states.

src/raftstore/store/peer.rs Outdated Show resolved Hide resolved
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

/run-all-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@kennytm kennytm added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 7, 2019
@Connor1996
Copy link
Member Author

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjinpeng87 zhangjinpeng87 merged commit b82ccfe into tikv:release-2.1 Apr 7, 2019
@Connor1996 Connor1996 deleted the fix-patch branch April 8, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/raft Component: Raft, RaftStore, etc. status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants