Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move util as a component #4504

Merged
merged 7 commits into from Apr 12, 2019

Conversation

Projects
None yet
6 participants
@BusyJay
Copy link
Contributor

BusyJay commented Apr 10, 2019

What have you changed? (mandatory)

Extract util module from the TiKV sources to a standalone sub-project. It's part of process to speed up compilation by reducing code inside TiKV projects.

What are the type of the changes? (mandatory)

  • Engineering

How has this PR been tested? (mandatory)

unit tests

Does this PR affect documentation (docs) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

#4165

*: move util as a component
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Apr 10, 2019

how about the rebuild time now?

@BusyJay

This comment has been minimized.

Copy link
Contributor Author

BusyJay commented Apr 10, 2019

No notable changes detected. But building channel benchmark is much faster than before now.

@ngaut

This comment has been minimized.

Copy link
Member

ngaut commented Apr 10, 2019

Good job.

@breeswish
Copy link
Member

breeswish left a comment

How long does it take to build channel benchmark now?

@breeswish

This comment has been minimized.

Copy link
Member

breeswish commented Apr 10, 2019

(related #3352)

@kennytm kennytm added the S: LGT1 label Apr 10, 2019

@brson
Copy link
Contributor

brson left a comment

Very straightforward refactor. Nice. I left one request to remove the tikv dep from test_util.

Show resolved Hide resolved components/test_util/Cargo.toml
address comment
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Merge branch 'master' into util-as-component
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

PTAL @brson

Merge branch 'master' into util-as-component
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@brson
Copy link
Contributor

brson left a comment

LGTM

@brson brson referenced this pull request Apr 11, 2019

Merged

*: add engine component #4461

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Apr 12, 2019

please fix the conflicts @BusyJay

@kennytm kennytm added S: LGT2 and removed S: LGT1 labels Apr 12, 2019

Merge branch 'master' into util-as-component
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Apr 12, 2019

@kennytm @brson

Please approve it again.

@breeswish breeswish merged commit 8dae71a into tikv:master Apr 12, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@BusyJay BusyJay deleted the BusyJay:util-as-component branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.