Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exec summary for limit executor #4599

Merged
merged 23 commits into from May 6, 2019

Conversation

Projects
None yet
4 participants
@breeswish
Copy link
Member

commented Apr 29, 2019

What have you changed? (mandatory)

Based on #4598, this PR adds exec summary support for the normal limit executor.

What are the type of the changes? (mandatory)

  • New feature (change which adds functionality)

How has this PR been tested? (mandatory)

Manually:

mysql> explain analyze select * from authors where last_name = 'Cole' limit 10;
+--------------------------+----------+------+------------------------------------------------------------------+-----------------------------------+
| id                       | count    | task | operator info                                                    | execution info                    |
+--------------------------+----------+------+------------------------------------------------------------------+-----------------------------------+
| Limit_8                  | 10.00    | root | offset:0, count:10                                               | time:13.178914ms, loops:2, rows:2 |
| └─TableReader_14         | 10.00    | root | data:Limit_13                                                    | time:13.175249ms, loops:2, rows:2 |
|   └─Limit_13             | 10.00    | cop  | offset:0, count:10                                               | time:9ms, loops:3, rows:2         |
|     └─Selection_12       | 10.00    | cop  | eq(test.authors.last_name, "Cole")                               | time:0s, loops:0, rows:0          |
|       └─TableScan_11     | 10000.00 | cop  | table:authors, range:[-inf,+inf], keep order:false, stats:pseudo | time:7ms, loops:101, rows:100     |
+--------------------------+----------+------+------------------------------------------------------------------+-----------------------------------+
5 rows in set (0.02 sec)

breeswish added some commits Apr 29, 2019

Rename and move ExecSummary to support non-batch executors
Signed-off-by: Breezewish <breezewish@pingcap.com>
Simplify exec summary to improve performance
Signed-off-by: Breezewish <breezewish@pingcap.com>
Collect execution summary in normal table scan and index scan
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge remote-tracking branch 'origin/master' into exec_summary_normal/2
Signed-off-by: Breezewish <breezewish@pingcap.com>
Support exec summary in limit
Signed-off-by: Breezewish <breezewish@pingcap.com>
Rename according to comments
Signed-off-by: Breezewish <breezewish@pingcap.com>
Add execution summary framework for non-batch executors
Signed-off-by: Breezewish <breezewish@pingcap.com>
Address comments:
- Rename to collect_exec_summary
- Remove unnecessary empty line

Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge branch 'exec_summary_normal/2.5' into exec_summary_normal/3
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge remote-tracking branch 'origin/master' into exec_summary_normal/3
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge branch 'exec_summary_normal/3' into exec_summary_normal/4
Signed-off-by: Breezewish <breezewish@pingcap.com>

@breeswish breeswish force-pushed the breeswish:exec_summary_normal/4 branch from bf23f85 to 4182662 May 5, 2019

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason added the S: LGT1 label May 5, 2019

breeswish added some commits May 5, 2019

@breeswish

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

/run-integration-tests

@lonng

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

/rebuid

Remove empty line
Signed-off-by: Breezewish <breezewish@pingcap.com>
@rleungx

rleungx approved these changes May 5, 2019

@breeswish

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

/run-integration-tests

@lonng

lonng approved these changes May 6, 2019

Copy link
Contributor

left a comment

LGTM

@lonng lonng added S: LGT2 and removed S: LGT1 labels May 6, 2019

breeswish added some commits May 6, 2019

@breeswish breeswish merged commit a1c0e46 into tikv:master May 6, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@breeswish breeswish deleted the breeswish:exec_summary_normal/4 branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.