Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cop_codegen to simplify some code #4622

Merged
merged 21 commits into from May 7, 2019

Conversation

Projects
None yet
4 participants
@breeswish
Copy link
Member

commented May 5, 2019

What have you changed? (mandatory)

Extracted from #3898

This PR moves macro into a custom derive, to further simplify the defining process of Rpn functions and batch aggregate functions.

This PR also includes a simple code simplification, changing xxx.map(|..| Error::Other(box_err!(..)))? to box_try!(xxx).

  • Merge #4626 first to resolve CI issue

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

Existing tests.

breeswish added some commits Apr 29, 2019

Add logical or
Signed-off-by: Breezewish <breezewish@pingcap.com>
Use LogicalOr in mapping function
Signed-off-by: Breezewish <breezewish@pingcap.com>
Add real compare functions
Signed-off-by: Breezewish <breezewish@pingcap.com>
Make code simpler
Signed-off-by: Breezewish <breezewish@pingcap.com>
Address comments to resolve some trivial issues
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge remote-tracking branch 'origin/master' into ___batch_extract/t6/2
Signed-off-by: Breezewish <breezewish@pingcap.com>
Introduce cop_codegen
Signed-off-by: Breezewish <breezewish@pingcap.com>
Merge remote-tracking branch 'origin/master' into ___batch_extract/t6/3
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breeswish

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

/run-integration-tests

@breeswish

This comment has been minimized.

Copy link
Member Author

commented May 5, 2019

CI failed because CI uses check-bin script from master instead of this PR. Will be fixed later.

breeswish and others added some commits May 5, 2019

Add missing piece
Signed-off-by: Breezewish <breezewish@pingcap.com>

breeswish added some commits May 7, 2019

Require explicit args = 0
Signed-off-by: Breezewish <breezewish@pingcap.com>
@lonng

lonng approved these changes May 7, 2019

Copy link
Contributor

left a comment

LGTM

@rleungx

rleungx approved these changes May 7, 2019

@kennytm

kennytm approved these changes May 7, 2019

@breeswish breeswish merged commit 7410bd3 into tikv:master May 7, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@breeswish breeswish deleted the breeswish:___batch_extract/t6/3 branch May 7, 2019

jswh added a commit to jswh/tikv that referenced this pull request May 27, 2019

Introduce cop_codegen to simplify some code (tikv#4622)
Signed-off-by: Breezewish <breezewish@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.