Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPN compare functions for Int, Decimal, String, Time, Duration and Json #4625

Merged
merged 25 commits into from May 8, 2019
Merged
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
64dcb35
Add logical or
breeswish Apr 29, 2019
d54896c
Use LogicalOr in mapping function
breeswish Apr 29, 2019
aaeea9c
Add real compare functions
breeswish Apr 29, 2019
64bb280
Merge branch 'master' into ___batch_extract/t6/1
breeswish May 1, 2019
cf6d6bb
Merge branch 'master' into ___batch_extract/t6/2
breeswish May 1, 2019
6c8038f
Merge branch 'master' into ___batch_extract/t6/1
breeswish May 5, 2019
a7a3632
Make code simpler
breeswish May 5, 2019
c89cbcd
Merge branch '___batch_extract/t6/1' into ___batch_extract/t6/2
breeswish May 5, 2019
5b5b327
Address comments to resolve some trivial issues
breeswish May 5, 2019
c3c3886
Merge remote-tracking branch 'origin/master' into ___batch_extract/t6/2
breeswish May 5, 2019
63ca260
Merge branch 'master' into ___batch_extract/t6/2
breeswish May 5, 2019
0374d1e
Introduce cop_codegen
breeswish May 5, 2019
05d18a8
Merge remote-tracking branch 'origin/master' into ___batch_extract/t6/3
breeswish May 5, 2019
4277ce5
Add compare functions for other data types
breeswish May 5, 2019
c9d2261
Merge branch 'master' into ___batch_extract/t6/3
breeswish May 5, 2019
6197a8e
Merge branch 'master' into ___batch_extract/t6/3
lonng May 6, 2019
1bf1df0
Merge branch 'master' into ___batch_extract/t6/3
breeswish May 6, 2019
0dff93f
Add missing piece
breeswish May 6, 2019
96f4aa0
Merge branch '___batch_extract/t6/3' into ___batch_extract/t6/4
breeswish May 6, 2019
44e0d21
Merge branch 'master' into ___batch_extract/t6/3
breeswish May 6, 2019
5cfc2b7
Require explicit args = 0
breeswish May 7, 2019
7e422ad
Merge branch '___batch_extract/t6/3' into ___batch_extract/t6/4
breeswish May 7, 2019
f11c949
Merge branch 'master' into ___batch_extract/t6/4
breeswish May 7, 2019
429bedd
Merge branch 'master' into ___batch_extract/t6/4
breeswish May 7, 2019
d5ed993
Merge branch 'master' into ___batch_extract/t6/4
breeswish May 8, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -9,7 +9,7 @@ use tipb::expression::FieldType;

use crate::coprocessor::codec::data_type::VectorValue;
use crate::coprocessor::codec::mysql::Tz;
use crate::coprocessor::codec::{Error, Result};
use crate::coprocessor::codec::Result;

/// A container stores an array of datums, which can be either raw (not decoded), or decoded into
/// the `VectorValue` type.
@@ -191,8 +191,7 @@ impl LazyBatchColumn {
return Ok(());
}

let eval_type =
EvalType::try_from(field_type.tp()).map_err(|e| Error::Other(box_err!(e)))?;
let eval_type = box_try!(EvalType::try_from(field_type.tp()));

let mut decoded_column = VectorValue::with_capacity(self.capacity(), eval_type);
{
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.