Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *AnyValue functions #4629

Merged
merged 4 commits into from May 7, 2019

Conversation

Projects
None yet
4 participants
@H-ZeX
Copy link
Contributor

commented May 5, 2019

What have you changed? (mandatory)

  • Add IntAnyValue, RealAnyValue, StringAnyValue, DurationAnyValue, TimeAnyValue, DecimalAnyValue, JsonAnyValue, and corresponding unit tests.
  • According to MySQL(8.0)' ANY_VALUE function's doc

    The function return value and type are the same as the return value and type of its argument, but the function result is not checked for the ONLY_FULL_GROUP_BY SQL mode

  • Just simply pick the first element if self.children.len()>0, otherwise return Ok(None).

What are the type of the changes? (mandatory)

  • New feature (change which adds functionality)

How has this PR been tested? (mandatory)

  • unit test

Does this PR affect documentation (docs) or release note? (mandatory)

  • no

Does this PR affect tidb-ansible update? (mandatory)

  • no

Refer to a related PR or issue link (optional)

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented May 5, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@H-ZeX H-ZeX force-pushed the H-ZeX:add_some_any_value_funcs branch from 4ed170f to 5863b6c May 6, 2019

coprocessor: Add some *AnyValue functions
Add new features

Signed-off-by: H-ZeX <hzx20112012@gmail.com>

@H-ZeX H-ZeX force-pushed the H-ZeX:add_some_any_value_funcs branch from 5863b6c to 4b32a62 May 6, 2019

@breeswish

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@AndreMouche PTAL, thanks!

@kennytm
Copy link
Contributor

left a comment

Rest LGTM

Show resolved Hide resolved src/coprocessor/dag/expr/builtin_miscellaneous.rs Outdated
refactor(builtin_miscellaneous *AnyValue): write them use combinator …
…and the use macro in tests

Signed-off-by: H-ZeX <hzx20112012@gmail.com>

@H-ZeX H-ZeX force-pushed the H-ZeX:add_some_any_value_funcs branch from d2f83b8 to 28fe5c8 May 6, 2019

@kennytm

kennytm approved these changes May 6, 2019

@breeswish

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Thanks a lot

@breeswish breeswish added the S: LGT2 label May 7, 2019

@H-ZeX

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Thank you very mush for your review!

@breeswish breeswish merged commit 279e8d3 into tikv:master May 7, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@breeswish

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.