Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc/txn: use raw_key in Error and reduce copy. #4631

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
4 participants
@youjiali1995
Copy link
Contributor

commented May 6, 2019

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What have you changed? (mandatory)

Use raw key in Error::TxnLockNotFound and use into_raw() to reduce copy.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

unit tests, intergration tests

Does this PR affect documentation (docs) or release note? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

mvcc/txn: use raw_key in Error and reduce copy.
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

@siddontang siddontang requested a review from zhangjinpeng1987 May 6, 2019

@zhangjinpeng1987
Copy link
Member

left a comment

LGTM

@Connor1996
Copy link
Member

left a comment

LGTM

@breeswish breeswish merged commit 1b39f6f into tikv:master May 6, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@youjiali1995 youjiali1995 deleted the youjiali1995:TxnLockNotFound-use-raw-key branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.