Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tipb_helper #4634

Merged
merged 7 commits into from May 8, 2019

Conversation

Projects
None yet
5 participants
@breeswish
Copy link
Member

commented May 6, 2019

What have you changed? (mandatory)

This PR introduce tipb_helper to build tipb structures more easily.

Extracted from #3898

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

No need.

@breeswish breeswish referenced this pull request May 6, 2019

Merged

Batch Simple Aggregation Executor #4635

1 of 1 task complete
Extract tipb_helper to standalone branch
Signed-off-by: Breezewish <breezewish@pingcap.com>

@breeswish breeswish force-pushed the breeswish:___batch_extract/t6/5 branch from c11e3d8 to c7fd2da May 7, 2019

@AndreMouche
Copy link
Member

left a comment

Rest LGTM

Show resolved Hide resolved components/tipb_helper/src/expr_def_builder.rs Outdated

breeswish added some commits May 7, 2019

Rename to push_child to be more clear
Signed-off-by: Breezewish <breezewish@pingcap.com>
ExprDefinitionBuilder change to ExprDefBuilder
Signed-off-by: Breezewish <breezewish@pingcap.com>
@lonng

lonng approved these changes May 8, 2019

Copy link
Contributor

left a comment

LGTM

@rleungx

rleungx approved these changes May 8, 2019

@breeswish breeswish merged commit 0609d44 into tikv:master May 8, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@breeswish breeswish deleted the breeswish:___batch_extract/t6/5 branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.