Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_worker: Fix the first safe_point sent to PD doesn't trigger GC #4641

Merged

Conversation

Projects
None yet
5 participants
@MyonKeminta
Copy link
Contributor

commented May 7, 2019

Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com

Use try_update_safe_point instead of wait_for_next_safe_point in GCManager's initialize method.

In the previous implementation, the first time the safe_point being sent to PD doesn't trigger GC, and GC will be triggerd when PD's safe_point is updated the second time.

What are the type of the changes? (mandatory)

  • Bug fix (change which fixes an issue)

How has this PR been tested? (mandatory)

By unit test

Does this PR affect documentation (docs) or release note? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Use try_update_safe_point instead of wait_for_next_safe_point
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@zhangjinpeng1987
Copy link
Member

left a comment

LGTM

MyonKeminta and others added some commits May 8, 2019

@breeswish breeswish added the S: LGT2 label May 8, 2019

@breeswish breeswish merged commit b70d50a into tikv:master May 8, 2019

@MyonKeminta MyonKeminta deleted the MyonKeminta:misono/gc-manager-init-immediately branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.