Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: skip check raft cf in delete range #4663

Merged
merged 3 commits into from May 9, 2019

Conversation

Projects
None yet
4 participants
@overvenus
Copy link
Member

commented May 9, 2019

What have you changed? (mandatory)

Skip deleting range check on raftcf, because the encoding of keys in raftcf is different from others, and there is no such usage in TiKV.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

No.

Does this PR affect documentation (docs) or release note? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

@overvenus overvenus requested review from BusyJay and zhangjinpeng1987 May 9, 2019

@overvenus overvenus force-pushed the overvenus:skip-raftcf branch from cb00bc4 to 3886a7e May 9, 2019

engine: skip check raft cf in delete range
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus force-pushed the overvenus:skip-raftcf branch from 3886a7e to f11c0c8 May 9, 2019

@zhangjinpeng1987
Copy link
Member

left a comment

LGTM

// Since CF_RAFT and CF_LOCK is usually small, so using
// traditional way to cleanup.
if use_delete_range && cf != CF_RAFT && cf != CF_LOCK {
if use_delete_range && cf != CF_LOCK {

This comment has been minimized.

Copy link
@Connor1996

Connor1996 May 9, 2019

Member

so should we add assert!(Cf != CF_RAFT)?

This comment has been minimized.

Copy link
@overvenus

overvenus May 9, 2019

Author Member

I don't think so, it's totally ok to delete range on the raft cf, because it deletes nothing. After #4372 is merged, it returns an error because there is no such cf.

@BusyJay

BusyJay approved these changes May 9, 2019

@Connor1996 Connor1996 added the S: LGT2 label May 9, 2019

@overvenus overvenus merged commit 190b6a1 into tikv:master May 9, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:skip-raftcf branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.