Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: tiny refactor for peer_storage #4668

Merged
merged 6 commits into from May 10, 2019

Conversation

Projects
None yet
3 participants
@overvenus
Copy link
Member

commented May 9, 2019

What have you changed? (mandatory)

init_apply_state/init_raft_state/init_last_term accept Engines instead of DB.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

Unit tests.

Does this PR affect documentation (docs) or release note? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

raftstore: tiny refactor for peer_storage
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus requested review from BusyJay, hicqu and Connor1996 May 9, 2019

overvenus added some commits May 9, 2019

}
}

impl Storage for PeerStorage {

This comment has been minimized.

Copy link
@Connor1996

Connor1996 May 9, 2019

Member

by the way, can you move struct PeerStorage right above it?

overvenus added some commits May 9, 2019

Address comments
Signed-off-by: Neil Shen <overvenus@gmail.com>
@Connor1996
Copy link
Member

left a comment

LGTM

@hicqu

hicqu approved these changes May 10, 2019

@overvenus overvenus merged commit ed07afe into tikv:master May 10, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:tweak-inits branch May 10, 2019

H-ZeX added a commit to H-ZeX/tikv that referenced this pull request May 11, 2019

raftstore: tiny refactor for peer_storage (tikv#4668)
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.