Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change coprocessor::dag::expr::builtin_math::test_rand_with_seed #4685

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
5 participants
@H-ZeX
Copy link
Contributor

commented May 11, 2019

Signed-off-by: H-ZeX hzx20112012@gmail.com

What have you changed? (mandatory)

  • Change coprocessor::dag::expr::builtin_math::test_rand_with_seed
  • Make it not depends on the internal impl of RandWithSeed
  • Test includes:
    • For same seed, the result of RandWithSeed is same.
    • For different seeds, the probability of same result is lower than a specific value.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

  • Unit test.

Does this PR affect documentation (docs) or release note? (mandatory)

  • No.

Does this PR affect tidb-ansible update? (mandatory)

  • No.

Refer to a related PR or issue link (optional)

#4667

coprocessor: change test_rand_with_seed
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@iosmanthus
Copy link
Contributor

left a comment

Rest LGTM 😃

Show resolved Hide resolved src/coprocessor/dag/expr/builtin_math.rs
Show resolved Hide resolved src/coprocessor/dag/expr/builtin_math.rs Outdated
coprocessor: change test_rand_with_seed, remove expect_same_probability
Signed-off-by: H-ZeX <hzx20112012@gmail.com>

@H-ZeX H-ZeX force-pushed the H-ZeX:modify_test_rand_with_seed branch from 16e2625 to febeec7 May 11, 2019

@kennytm

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

/test

@kennytm kennytm merged commit 22426f9 into tikv:master May 14, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

jswh added a commit to jswh/tikv that referenced this pull request May 27, 2019

change coprocessor::dag::expr::builtin_math::test_rand_with_seed (tik…
…v#4685)

* coprocessor: change test_rand_with_seed

Signed-off-by: H-ZeX <hzx20112012@gmail.com>

* coprocessor: change test_rand_with_seed, remove expect_same_probability

Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.