Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement a common layer Aggr Executors #4747
Merged
Conversation
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
…/2-1
…/2-1
…/4-1
Signed-off-by: Breezewish <breezewish@pingcap.com>
This comment has been minimized.
This comment has been minimized.
|
/run-integration-tests |
|
LGTM |
jswh
added a commit
to jswh/tikv
that referenced
this pull request
May 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
breeswish commentedMay 21, 2019
•
edited
What have you changed? (mandatory)
This PR introduces a common layer called
AggregationExecutorfor HashAggr, SimpleAggr and StreamAggr.SimpleAggr is also re-organized to utilize
AggregationExecutor.What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Existing unit tests.