Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a common layer Aggr Executors #4747

Merged
merged 20 commits into from May 22, 2019

Conversation

@breeswish
Copy link
Member

breeswish commented May 21, 2019

What have you changed? (mandatory)

This PR introduces a common layer called AggregationExecutor for HashAggr, SimpleAggr and StreamAggr.

SimpleAggr is also re-organized to utilize AggregationExecutor.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

Existing unit tests.

breeswish added 18 commits May 20, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
…/2+4/1
breeswish added 2 commits May 22, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breeswish

This comment has been minimized.

Copy link
Member Author

breeswish commented May 22, 2019

/run-integration-tests

Copy link
Contributor

sticnarf left a comment

LGTM

@breeswish breeswish merged commit 850779f into tikv:master May 22, 2019
5 checks passed
5 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@breeswish breeswish deleted the breeswish:___batch_extract/t7/2+4/1 branch May 22, 2019
jswh added a commit to jswh/tikv that referenced this pull request May 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.