Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sys-info #4760

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
5 participants
@brson
Copy link
Contributor

commented May 24, 2019

This fixes a regression linking to the native get_mem_info function when upgrading the next toolchain.

What have you changed? (mandatory)

Bumped sys-info from 0.5.1 to 0.5.6.

While testing cargo pipelining I needed to use a newer toolchain. That toolchain failed to link the native parts of the sys-info crate. Upgrading sys-info fixes it for whatever reason. Doesn't seem worth investigating.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

cargo build

Does this PR affect documentation (docs) or release note? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@brson brson force-pushed the brson:sys-info-up branch 2 times, most recently from 675b3bf to cc559fa May 24, 2019

*: upgrade sys-info crate
This fixes a problem with the next toolchain upgrade
where rust fails to link the native components of the crate.

Signed-off-by: Brian Anderson <andersrb@gmail.com>

@brson brson force-pushed the brson:sys-info-up branch from cc559fa to fe59bb7 May 24, 2019

@kennytm
Copy link
Contributor

left a comment

LGTM

source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
"gcc 0.3.54 (registry+https://github.com/rust-lang/crates.io-index)",
"cc 1.0.28 (registry+https://github.com/rust-lang/crates.io-index)",

This comment has been minimized.

Copy link
@kennytm

kennytm May 24, 2019

Contributor

This updated dependency should be the reason 😉

This comment has been minimized.

Copy link
@brson

brson May 24, 2019

Author Contributor

Probably!

@brson

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

This PR causes panics on WSL, and probably pre-3.4 linuxes. @Hoverbear has a fix for sys-info at FillZpp/sys-info-rs#33.

@kennytm

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Should we wait for FillZpp/sys-info-rs#33 or just merge this PR now?

@brson

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

I think @Hoverbear is ok with merging it, and this unblocks cargo pipelining. PTAL @Hoverbear

@brson brson requested a review from Hoverbear May 27, 2019

@brson

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

If we want to we can take another git dependency on sys-info temporarily. I'm happy to make that change here.

@Hoverbear

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Lgtm

@Hoverbear

This comment has been minimized.

Copy link
Member

commented May 29, 2019

(side note that PR is merged. Should we ask for a new release?)

@kennytm

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

We could upgrade to 0.5.7 now

@brson brson dismissed stale reviews from siddontang and kennytm via 7779649 Jun 3, 2019

*: bump sys-info to 0.5.7
Signed-off-by: Brian Anderson <andersrb@gmail.com>

@brson brson force-pushed the brson:sys-info-up branch from 7779649 to d2fefe8 Jun 3, 2019

@brson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

OK, sys-info is now 0.5.7. PTAL @Hoverbear @kennytm

@kennytm

kennytm approved these changes Jun 4, 2019

@kennytm

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

/run-integration-tests

@kennytm kennytm merged commit 9a14c49 into tikv:master Jun 4, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

sticnarf added a commit to sticnarf/tikv that referenced this pull request Jun 10, 2019

Remove all Box of RPN functions
Signed-off-by: Yilin Chen <sticnarf@gmail.com>

Makefile: make sure gdb is installed before sse4.2 check (tikv#4832)

Signed-off-by: Kaige Ye <ye@kaige.org>

Upgrade sys-info (tikv#4760)

* *: upgrade sys-info crate

This fixes a problem with the next toolchain upgrade
where rust fails to link the native components of the crate.

Signed-off-by: Brian Anderson <andersrb@gmail.com>

* *: bump sys-info to 0.5.7

Signed-off-by: Brian Anderson <andersrb@gmail.com>

Batch Top N Executor (tikv#4825)

Signed-off-by: Breezewish <breezewish@pingcap.com>

Add help message in doc:go-client-api.md (tikv#4763)

* add help message in doc:go-client-api.md

Signed-off-by: yy <cacheyy@qq.com>

* update go-client-api.md

Signed-off-by: yy <cacheyy@qq.com>

Modify Makefile to distinguish between developer and packaging use cases (tikv#4687)

* make: Add new "dist_release" rules

To make the optimized build faster the existing "release" rules are going to
changed such that they are not identical to the actual releases. Primarily they
will not have debuginfo by default and will use thinLTO instead of LTO.

This adds new "dist_release", etc rules for the CI/CD system to use.

For now they are identical to the existing rules. After CI is updated
the "release" rules will be changed.

Signed-off-by: Brian Anderson <andersrb@gmail.com>

* make: Document release rules

Signed-off-by: Brian Anderson <andersrb@gmail.com>

* Makefile: indicate use of fail_release

Signed-off-by: Brian Anderson <andersrb@gmail.com>

* Clarify the distinction in instruction set for release targets

Signed-off-by: Brian Anderson <andersrb@gmail.com>

Makefile: fix gdb check (tikv#4840)

Signed-off-by: Kaige Ye <ye@kaige.org>

pessimistic-txn: solve non-pessimistic-lock conflict (tikv#4801)

* txn: replace is_pessimistic_lock to for_update_ts in Lock

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* pessimistic-txn: overwrite optimistic lock in pessimistic_prewrite if
request's for_update_ts is greater than lock's for_update_ts

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* modify comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* address comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* address comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* address comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* address comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* add comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* return Error let TiDB to resolve lock

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* address comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

* address comment

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

coprocessor: add batch aggregate function BitAnd/BitOr/BitXor (tikv#4824)

Batch Top N Layered Benchmarks (tikv#4827)

* Add Top N benchmarks

Signed-off-by: Breezewish <breezewish@pingcap.com>

* Address some comments in previous PRs

Signed-off-by: Breezewish <breezewish@pingcap.com>

coprocessor: add batch aggregate function Max/Min (tikv#4837)

Implement RpnFunction MultiplyDecimal (tikv#4849)

Signed-off-by: Breezewish <breezewish@pingcap.com>

Add missing fsync calls in the snapshot module (tikv#4850)

Signed-off-by: Ben Pig Chu <benpichu@gmail.com>

use HTTP to enable jemalloc profile (tikv#4600)

use HTTP to enable jemalloc profile

Signed-off-by: Yang Keao <keao.yang@yahoo.com>

coprocessor: use servo_arc in BatchTopNExecutor (tikv#4854)

Signed-off-by: Yilin Chen <sticnarf@gmail.com>

Fix clippy warnings

Signed-off-by: Yilin Chen <sticnarf@gmail.com>

Fix test

Signed-off-by: Yilin Chen <sticnarf@gmail.com>

Add docs to function.rs

Signed-off-by: Yilin Chen <sticnarf@gmail.com>

Add example output of the macro in the test of the macro.

Signed-off-by: Yilin Chen <sticnarf@gmail.com>

fix broken url for configuration options (tikv#4856)

Signed-off-by: Yukang <moorekang@gmail.com>

shrink the latch waiting list (tikv#4844)

Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>

Fix clippy

Signed-off-by: Yilin Chen <sticnarf@gmail.com>

scheduler use spin::Mutex (tikv#4829)

* scheduler use spinlock

Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>

Better panic info

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.