Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1: return region error when TiKV is closing #4820

Merged

Conversation

@zhangjinpeng1987
Copy link
Member

zhangjinpeng1987 commented Jun 1, 2019

Signed-off-by: zhangjinpeng1987 zhangjinpeng@pingcap.com

What have you changed? (mandatory)

Return an RegionError when TiKV is closing to tell the client that this region is unavailable temporarily, the client should retry the request in other TiKVs.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

  • killing test

Does this PR affect documentation (docs) or release note? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
@zhangjinpeng1987

This comment has been minimized.

Copy link
Member Author

zhangjinpeng1987 commented Jun 1, 2019

/release

@zhangjinpeng1987

This comment has been minimized.

Copy link
Member Author

zhangjinpeng1987 commented Jun 11, 2019

Please don't close, still running long time stability test.

@zhangjinpeng1987

This comment has been minimized.

Copy link
Member Author

zhangjinpeng1987 commented Jul 19, 2019

After 1 month long time testing, i think we can merge it. @disksing @AndreMouche PTAL

Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
@AndreMouche AndreMouche merged commit e8e295f into tikv:release-2.1 Jul 23, 2019
2 checks passed
2 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@ngaut ngaut changed the title [DNM] 2.1: return region error when TiKV is closing 2.1: return region error when TiKV is closing Jul 23, 2019
@AndreMouche AndreMouche removed the S: DNM label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.