Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pessimistic-txn: add metrics #4852

Merged
merged 3 commits into from Jun 10, 2019
Merged

Conversation

@youjiali1995
Copy link
Contributor

youjiali1995 commented Jun 6, 2019

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What have you changed? (mandatory)

Added metrics:

  • TASK_COUNTER_VEC: count tasks handled.
  • ERROR_COUNTER_VEC: count errors.
  • WAITER_LIFETIME_HISTOGRAM: measure how long a waiter is waked up.
  • DETECT_DURATION_HISTOGRAM: measure how long detect requests cost, and it can reflect which node is the leader of deadlock detector.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

manual test
image
image

Does this PR affect documentation (docs) or release note? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

yes. pingcap/tidb-ansible#772

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@AndreMouche AndreMouche self-assigned this Jun 6, 2019
@AndreMouche AndreMouche self-requested a review Jun 6, 2019
@AndreMouche AndreMouche added the C: Txn label Jun 6, 2019
Copy link
Member

zhangjinpeng1987 left a comment

LGTM

Copy link
Member

AndreMouche left a comment

LGTM,Please fix the conflits

…trics

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995 youjiali1995 force-pushed the youjiali1995:pessimistic-txn-metrics branch from ea0a283 to fcb3a29 Jun 10, 2019
@youjiali1995

This comment has been minimized.

Copy link
Contributor Author

youjiali1995 commented Jun 10, 2019

Copy link
Member

zhangjinpeng1987 left a comment

LGTM

@youjiali1995 youjiali1995 merged commit 9e0218d into tikv:master Jun 10, 2019
2 checks passed
2 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@youjiali1995 youjiali1995 deleted the youjiali1995:pessimistic-txn-metrics branch Jun 10, 2019
youjiali1995 added a commit to youjiali1995/tikv that referenced this pull request Jun 13, 2019
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
youjiali1995 added a commit to youjiali1995/tikv that referenced this pull request Jun 13, 2019
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.