Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: add titan key only option #4966

Merged
merged 15 commits into from Jul 3, 2019

Conversation

Projects
None yet
5 participants
@Connor1996
Copy link
Member

commented Jun 24, 2019

What have you changed? (mandatory)

Cause DeleteFilesInRange may expose old blob index keys, setting key only for Titan to avoid referring to missing blob files.

What are the type of the changes? (mandatory)

  • Bug fix (change which fixes an issue)

How has this PR been tested? (mandatory)

unit-test

Does this PR affect documentation (docs) or release note? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Connor1996 added some commits Jun 20, 2019

reproduce default not found
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
make format
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
add titan key only option
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Connor1996 added some commits Jun 24, 2019

add titan key only option
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
fix titan
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
update titan
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 force-pushed the Connor1996:update-titan branch from 76f5c67 to 58a672b Jun 24, 2019

Connor1996 added some commits Jun 24, 2019

update titan
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
add config
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@siddontang

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

IMO, we should provide a Trait that can support Key only operations, not only for Titan.

Connor1996 added some commits Jun 24, 2019

[release-3.0] engine: add titan key only option (#4969)
* add titan key only option

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
fix
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
add delete files in range test
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

@siddontang Okay, I will extract a trait later. Let's keep this and fix the issue first.

@Connor1996

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

@yiwu-arbug
Copy link
Contributor

left a comment

LGTM

@zhangjinpeng1987
Copy link
Member

left a comment

LGTM

@zhangjinpeng1987

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Build failed

error[E0061]: this function takes 0 parameters but 1 parameter was supplied

   --> src/raftstore/store/region_snapshot.rs:808:20

    |

808 |         let path = TempDir::new("test-titan-delete-files-in-range").unwrap();

    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 0 parameters



error[E0061]: this function takes 0 parameters but 1 parameter was supplied

    --> src/raftstore/store/region_snapshot.rs:1018:20

     |

1018 |         let dir1 = TempDir::new("test-snap-cf-db-apply").unwrap();

     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 0 parameters



error: aborting due to 2 previous errors

fix temp dir
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 dismissed stale reviews from zhangjinpeng1987 and yiwu-arbug via a7527b7 Jul 3, 2019

@Connor1996 Connor1996 added the S: LGT2 label Jul 3, 2019

@Connor1996

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

build fixed. PTAL again @yiwu-arbug @zhangjinpeng1987

@@ -77,7 +77,7 @@ fn memory_mb_for_cf(is_raft_db: bool, cf: &str) -> usize {
#[serde(default)]
#[serde(rename_all = "kebab-case")]
pub struct TitanCfConfig {
pub min_blob_size: u64,
pub min_blob_size: ReadableSize,

This comment has been minimized.

Copy link
@overvenus

overvenus Jul 3, 2019

Contributor

Does it compactable with pervious config?

This comment has been minimized.

Copy link
@Connor1996

Connor1996 Jul 3, 2019

Author Member

Yes

@Connor1996 Connor1996 merged commit 0d916aa into tikv:master Jul 3, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@Connor1996 Connor1996 deleted the Connor1996:update-titan branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.