Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
*: Add mimalloc feature to tikv_alloc #5041
Signed-off-by: Yilin Chen firstname.lastname@example.org
What have you changed? (mandatory)
This PR adds mimalloc support to TiKV. To use mimalloc as the allocator of TiKV, set
MIMALLOC=1 make dist_release
The mimalloc crate used is https://github.com/gnzlbg/mimallocator whose maintainer is the same as jemallocator's.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Does this PR affect documentation (docs) or release note? (mandatory)
Does this PR affect tidb-ansible update? (mandatory)
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
A little improvement under sysbench while a little regression under go-ycsb. It should be investigated more.
Add a few positive/negative examples (optional)
After a second test, I am confident it's not a mistake that sysbench and go-ycsb give different results.
I think it just tells us mimalloc does not work better in every case. When value size differs, allocation size and frequency can differ too. No allocator can handle every case well.