Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.1] Unified Log Format #5083

Merged

Conversation

@breeswish
Copy link
Member

breeswish commented Jul 13, 2019

Signed-off-by: Breezewish breezewish@pingcap.com

What have you changed? (mandatory)

This PR cherry picks the unified log format formatter from 3.0 to 2.1.

Note: This PR does not introduce fields for log items.

What are the type of the changes? (mandatory)

  • New feature (change which adds functionality)

How has this PR been tested? (mandatory)

Manually and unit tests:

$ target/debug/tikv-server
[2019/07/13 11:44:14.561 +08:00] [INFO] [mod.rs:26] ["Welcome to TiKV. \nRelease Version:   2.1.14\nGit Commit Hash:   Unknown (env var does not exist when building)\nGit Commit Branch: Unknown (env var does not exist when building)\nUTC Build Time:    Unknown (env var does not exist when building)\nRust Version:      Unknown (env var does not exist when building)"]
[2019/07/13 11:44:14.563 +08:00] [INFO] [config.rs:152] ["no advertise-addr is specified, fall back to addr."]
[2019/07/13 11:44:14.564 +08:00] [ERROR] [tikv-server.rs:441] ["invalid configuration: StringError(\"please specify pd.endpoints.\")"]
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breeswish

This comment has been minimized.

Copy link
Member Author

breeswish commented Jul 13, 2019

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@breeswish

This comment has been minimized.

Copy link
Member Author

breeswish commented Jul 13, 2019

@breeswish

This comment has been minimized.

Copy link
Member Author

breeswish commented Jul 13, 2019

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

1 similar comment
@youjiali1995

This comment has been minimized.

Copy link
Contributor

youjiali1995 commented Jul 13, 2019

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@BusyJay

This comment has been minimized.

Copy link
Contributor

BusyJay commented Jul 13, 2019

Why change the log format for 2.1? I think only bugfix is accepted.

@breeswish

This comment has been minimized.

Copy link
Member Author

breeswish commented Jul 13, 2019

@BusyJay Required by TEP team. I don't want to change it either.

@mahjonp

This comment has been minimized.

Copy link
Contributor

mahjonp commented Jul 15, 2019

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Jul 15, 2019

PTAL @BusyJay

@youjiali1995 youjiali1995 merged commit 35f0b38 into tikv:release-2.1 Jul 17, 2019
5 checks passed
5 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@breeswish breeswish deleted the breeswish:release-2.1-unified-log-format branch Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.