Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rust to nightly-2019-07-19 #5137

Merged
merged 8 commits into from Aug 6, 2019

Conversation

@brson
Copy link
Contributor

commented Jul 26, 2019

What have you changed? (mandatory)

Upgrade the toolchain in an attempt to fix likely pipelining error, "error: crate librocksdb_sys required to be available in rlib format, but was not found in this form". re
#5130

As noted on the issue, a pipelining bug was fixed after we adopted pipelining. This upgrade may fix the error @BusyJay and others have been seeing.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

make dev

Does this PR affect documentation (docs) or release note? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Refer to a related PR or issue link (optional)

#5130

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@brson brson requested review from nrc, AndreMouche and overvenus Jul 26, 2019

@siddontang
Copy link
Contributor

left a comment

LGTM

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

you also need to run ./scripts/gen-dockerfile.sh to update the toolchain in docker.

@breeswish

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

You will need to update the docker file as suggested by @siddontang and also sign off your commits :)

@breeswish

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Additionally CI failed because of some deprecate notes maybe you need to take a look.

@BusyJay

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Is #4301 resolved by this version?

@brson brson dismissed stale reviews from breeswish and siddontang via 8d9eb1f Jul 26, 2019

@brson brson force-pushed the brson:rustup branch from ff102ac to 8d9eb1f Jul 26, 2019

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

CI still failed @brson

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Ping @brson

@brson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

I'm still working through clippy changes.

@brson brson force-pushed the brson:rustup branch from 2feca20 to baf69a5 Aug 2, 2019

brson added some commits Jul 24, 2019

Upgrade to nightly-2019-07-19
Just a stab-in-the-dark to fix potential pipelining bug #5130

Signed-off-by: Brian Anderson <andersrb@gmail.com>
*: rustfmt
Signed-off-by: Brian Anderson <andersrb@gmail.com>
docker: regenerate
Signed-off-by: Brian Anderson <andersrb@gmail.com>
*: cleanup lints and clippy
Signed-off-by: Brian Anderson <andersrb@gmail.com>

@brson brson force-pushed the brson:rustup branch from f3581ce to d088089 Aug 2, 2019

*: clippy and rustfmt
Signed-off-by: Brian Anderson <andersrb@gmail.com>

@brson brson force-pushed the brson:rustup branch from d088089 to 540a43b Aug 2, 2019

@brson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

This is updated to fix all the clippy lints. I tried updated to a newer toolchain but they are broken with an error about "unrecognized option: json-rendered".

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

The rest looks good to me and I will approve it once CI is passed :)

@nrc
Copy link
Contributor

left a comment

lgtm

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

em, CI still failed

maybe we need to upgrade to the latest toolchain?

breeswish added some commits Aug 6, 2019

Fix warnings
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/run-all-tests

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/run-all-tests

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/run-integration-ddl-test

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/run-integration-compatibility-test

@breeswish breeswish merged commit 053e232 into tikv:master Aug 6, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.