Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: adjust log level #5184

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@disksing
Copy link
Collaborator

commented Aug 2, 2019

Signed-off-by: disksing i@disksing.com

What have you changed? (mandatory)

Use INFO log level for some frequent and irrelevant errors.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

no test.

Does this PR affect documentation (docs) or release note? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

storage: adjust log level
Signed-off-by: disksing <i@disksing.com>
@kennytm

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

/test

#5188.

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

maybe warm is better?

@breeswish
Copy link
Member

left a comment

@disksing Do you think it's necessary to use WARN? If not, then this PR can be merged directly.

@disksing

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 5, 2019

@siddontang @breeswish The log specification says "warn level is a log that requires manual attention."
The problem here is usually restored by retrying, and it occurs very frequently. So I guess it should not require manual attention.

@breeswish breeswish merged commit 4b0005f into tikv:master Aug 5, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

cherry pick to release-3.0 in PR #5193

@disksing disksing deleted the disksing:adjust-log-level branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.