Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: Fix STORE_ENGINE_SIZE metrics #5187

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@Connor1996
Copy link
Member

commented Aug 2, 2019

What have you changed? (mandatory)

make STORE_ENGINE_SIZE including the size of memtable and blob files.

What are the type of the changes? (mandatory)

  • Bug fix (change which fixes an issue)

How has this PR been tested? (mandatory)

manual-test

Does this PR affect documentation (docs) or release note? (mandatory)

No

fix STORE_ENGINE_SIZE
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@siddontang

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

make STORE_ENGINE_SIZE including the size of memtable and blob files.

seems the previous implementation contains memtable and blob files already.

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

btw, where is the test?

@Connor1996

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

@siddontang The used size sent to PD includes these, but STORE_ENGINE_SIZE does not. And it is just metrics, hard to add test and unnecessary.

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@Connor1996 Do you want to carry this PR's cherry pick in 3.0.2?

@Connor1996

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

@yiwu-arbug
Copy link
Contributor

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit 58414da into tikv:master Aug 5, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

cherry pick to release-3.0 in PR #5200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.