Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv-ctl: Fix region size command #5194

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@Connor1996
Copy link
Member

commented Aug 5, 2019

What have you changed? (mandatory)

region size command doesn't consider the key's size.

What are the type of the changes? (mandatory)

  • Bug fix (change which fixes an issue)

How has this PR been tested? (mandatory)

unit-test

Does this PR affect documentation (docs) or release note? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

fix tikv-ctl region size command
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@MyonKeminta
Copy link
Contributor

left a comment

LGTM

@nolouch

nolouch approved these changes Aug 5, 2019

@nolouch nolouch added the S: CanMerge label Aug 5, 2019

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit af77c60 into tikv:master Aug 5, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

cherry pick to release-3.0 in PR #5195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.