Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move pd to independent crate #5210

Merged
merged 4 commits into from Aug 7, 2019

Conversation

@siddontang
Copy link
Contributor

commented Aug 6, 2019

Signed-off-by: siddontang siddontang@gmail.com

What have you changed? (mandatory)

Move PD to independent crate in components.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

Passing CI is ok

Does this PR affect documentation (docs) or release note? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

*: move pd to independent crate
Signed-off-by: siddontang <siddontang@gmail.com>

@siddontang siddontang requested review from breeswish and overvenus Aug 6, 2019

src/lib.rs Outdated
@@ -55,6 +55,7 @@ extern crate vlog;
extern crate tikv_util;
#[macro_use]
extern crate failure;
extern crate pd;

This comment has been minimized.

Copy link
@sticnarf

sticnarf Aug 6, 2019

Contributor

It seems unnecessary now.

*: remove unnecessary crate pd
Signed-off-by: siddontang <siddontang@gmail.com>
@@ -6,6 +6,7 @@ extern crate slog;
extern crate slog_global;
#[macro_use]
extern crate tikv_util;
extern crate pd as tikv_pd;

This comment has been minimized.

Copy link
@overvenus

overvenus Aug 6, 2019

Contributor

Why not just pd?

This comment has been minimized.

Copy link
@breeswish

This comment has been minimized.

Copy link
@siddontang

siddontang Aug 6, 2019

Author Contributor

because the directory contains a pd.rs file.

@breeswish
Copy link
Member

left a comment

The rest LGTM

@@ -21,3 +21,4 @@ slog = { version = "2.3", features = ["max_level_trace", "release_max_level_debu
slog-global = { version = "0.1", git = "https://github.com/breeswish/slog-global.git", rev = "91904ade" }
engine = { path = "../engine" }
hex = "0.3"
pd = { path = "../pd" }

This comment has been minimized.

Copy link
@breeswish

breeswish Aug 6, 2019

Member

trailing new line

@@ -6,6 +6,7 @@ extern crate slog;
extern crate slog_global;
#[macro_use]
extern crate tikv_util;
extern crate pd as tikv_pd;

This comment has been minimized.

Copy link
@breeswish
@@ -5,7 +5,7 @@ use std::thread;
use std::time::Duration;

use kvproto::pdpb::*;
use tikv::pd::RECONNECT_INTERVAL_SEC;
use pd::RECONNECT_INTERVAL_SEC;

This comment has been minimized.

Copy link
@breeswish

breeswish Aug 6, 2019

Member

pd? tikv_pd?

@@ -0,0 +1,32 @@
[package]
name = "pd"

This comment has been minimized.

Copy link
@breeswish

breeswish Aug 6, 2019

Member

maybe tikv_pd or pd_client is better to avoid someone thinking that it is the PD.

This comment has been minimized.

Copy link
@siddontang

siddontang Aug 6, 2019

Author Contributor

oh, seem it is better to rename to pd_client?
/cc @overvenus

This comment has been minimized.

Copy link
@overvenus

overvenus Aug 6, 2019

Contributor

Good idea!

*: renmae crate pd to pd_client
Signed-off-by: siddontang <siddontang@gmail.com>
@siddontang

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@breeswish
Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

/run-all-tests

@sre-bot sre-bot merged commit 35e800c into tikv:master Aug 7, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.