Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: introduce SstWriterBuilder #5211

Merged
merged 9 commits into from Aug 6, 2019

Conversation

@overvenus
Copy link
Contributor

commented Aug 6, 2019

What have you changed? (mandatory)

Introduce SstWriterBuilder, it builds a SstWriter which support building an in-memory SST.

For now, no one uses in-memory sst, it is added for backup, it helps backup increasing throughput by not performing any IO operation.

What are the type of the changes? (mandatory)

  • New feature (change which adds functionality)

How has this PR been tested? (mandatory)

Unit tests.

Does this PR affect documentation (docs) or release note? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

overvenus added some commits Aug 3, 2019

engine: add SstWriterBuilder
Signed-off-by: Neil Shen <overvenus@gmail.com>
engine: builder in-memory sst file writer
Signed-off-by: Neil Shen <overvenus@gmail.com>
engine/sst: fill doc
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus requested review from Connor1996 and 5kbpers Aug 6, 2019

@overvenus overvenus added the C: RocksDB label Aug 6, 2019

fix typo
Signed-off-by: Neil Shen <overvenus@gmail.com>
@siddontang

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

why do we need to build a memory SST?
when can we use it?

@overvenus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

@siddontang Good questions! Answered in the PR description.

engine: use ok_or_else instead
Signed-off-by: Neil Shen <overvenus@gmail.com>
@5kbpers
Copy link
Member

left a comment

LGTM

@Connor1996
Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

@overvenus merge failed.

@overvenus overvenus dismissed stale reviews from Connor1996 and 5kbpers via c722abf Aug 6, 2019

@Connor1996
Copy link
Member

left a comment

LGTM

@5kbpers

5kbpers approved these changes Aug 6, 2019

Copy link
Member

left a comment

LGTM again

@5kbpers 5kbpers merged commit 078dd23 into tikv:master Aug 6, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.