Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `codec::Error` more ergonomic #5216

Merged

Conversation

@iosmanthus
Copy link
Contributor

commented Aug 6, 2019

Signed-off-by: Iosmanthus Teng myosmanthustree@gmail.com

What have you changed? (mandatory)

Currently, functions like: Error::overflow only accept &str as parameters which will be inconvenient since we need to convert the value into a string and derefs it as a &str, we can add Display trait bound to parameters which make it easy to use.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

No need to test. cargo check --all-targets

Make `codec::Error` more ergonomic
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

@iosmanthus iosmanthus requested review from breeswish, lonng and sticnarf Aug 6, 2019

iosmanthus added some commits Aug 6, 2019

remove generic parameters
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

@iosmanthus iosmanthus requested a review from breeswish Aug 6, 2019

@sticnarf
Copy link
Contributor

left a comment

LGTM

@lonng

lonng approved these changes Aug 6, 2019

@sticnarf sticnarf added the S: CanMerge label Aug 6, 2019

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3deaaed into tikv:master Aug 6, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.