Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft: temporarily use raft-rs master branch #5228

Merged
merged 3 commits into from Aug 9, 2019

Conversation

@hicqu
Copy link
Contributor

commented Aug 8, 2019

Signed-off-by: qupeng qupeng@pingcap.com

What have you changed? (mandatory)

Use raft-rs master branch to include some bug fixes:

@sre-bot sre-bot added the S: BotClose label Aug 8, 2019

@sre-bot sre-bot closed this Aug 8, 2019

@hicqu hicqu reopened this Aug 8, 2019

@kennytm kennytm removed the S: BotClose label Aug 8, 2019

@tikv tikv deleted a comment from sre-bot Aug 8, 2019

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

why temporarily use?

raft: temporarily use raft-rs master branch
Signed-off-by: qupeng <qupeng@pingcap.com>

@hicqu hicqu force-pushed the hicqu:use-raft-master branch from 4c47e9a to 5473b93 Aug 9, 2019

@hicqu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@siddontang after new version of raft-rs is published, we can switch the dependency to crates-io.

@overvenus

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Does it need to be cherry-picked to release-3.0?

@hicqu hicqu added the T: BugFix label Aug 9, 2019

@hicqu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@overvenus 2 bugs are only in master branch, because release-3.0 doesn't use raft-rs master branch.

@BusyJay

BusyJay approved these changes Aug 9, 2019

@hicqu hicqu merged commit 88b71fb into tikv:master Aug 9, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@hicqu hicqu deleted the hicqu:use-raft-master branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.