Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: fix last_report_ts in region heartbeat (#5248) #5296

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 19, 2019

cherry-pick #5248 to release-3.0


What have you changed? (mandatory)

Currently, the value of last_report_ts in region's heartbeat is limited by the region_heartbeat_interval, which will cause the amount of recorded IOs do not correspond to the time interval, therefore may impact the calculation of flow information in PD.

What are the type of changes? (mandatory)

  • Bugfix (a change which fixes an issue)

How has this PR been tested? (mandatory)

make dev

Does this PR affect documentation (docs) or release note? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

* add unit test to test report timestamp

Signed-off-by: jiyingtk <jiyingtk@mail.ustc.edu.cn>
@sre-bot

This comment has been minimized.

Copy link
Collaborator Author

sre-bot commented Aug 19, 2019

/run-all-tests

@lonng
lonng approved these changes Aug 21, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator Author

sre-bot commented Aug 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit d5f2301 into tikv:release-3.0 Aug 21, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.