Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: add backup service #5359

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@overvenus
Copy link
Contributor

commented Aug 29, 2019

What have you changed?

Add backup service. It accepts backup requests and forwards to a backup endpoint which does the actual backup.

Note: The endpoint is a plain stub, and will be implemented in upcoming PRs.

What is the type of the changes?

  • New feature (a change which adds functionality)

How is the PR tested?

Unit test.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No.

Does this PR affect tidb-ansible?

No.

backup: add backup service
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus requested review from zhangjinpeng1987 and 5kbpers Aug 29, 2019

@@ -194,7 +194,6 @@ pub fn default_not_found_error(key: Vec<u8>, write: Write, hint: &str) -> Error
}
}

#[cfg(test)]

This comment has been minimized.

Copy link
@Connor1996

Connor1996 Sep 2, 2019

Member

why remove

This comment has been minimized.

Copy link
@overvenus

overvenus Sep 2, 2019

Author Contributor

The test test_client_stop does not compile without the change.

components/backup/src/service.rs Outdated Show resolved Hide resolved
overvenus added 2 commits Sep 2, 2019
address comments
Signed-off-by: Neil Shen <overvenus@gmail.com>
Merge branch 'master' into backup/service
Signed-off-by: Neil Shen <overvenus@gmail.com>
@Connor1996
Copy link
Member

left a comment

LGTM

@5kbpers
5kbpers approved these changes Sep 3, 2019

@5kbpers 5kbpers added the S: CanMerge label Sep 3, 2019

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1931665 into tikv:master Sep 3, 2019

6 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:backup/service branch Sep 3, 2019

YangKeao added a commit to YangKeao/tikv that referenced this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.