Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: continue to use openssl #5384

Merged
merged 3 commits into from Sep 6, 2019

Conversation

@rleungx
Copy link
Member

commented Sep 2, 2019

What have you changed?

This PR fixes the TLS by removing libressl and uses openssl instead.

[2019/09/02 19:15:07.420 +08:00] [ERROR] [lockfree_event.cc:164] ["LockfreeEvent::SetShutdown: 0x7fe060c20070 curr=(nil) err={\"created\":\"@1567422907.350403400\",\"description\":\"Delayed close due to in-progress write\",\"file\":\"/home/ryan/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0-alpha.4/grpc/src/core/ext/transport/chttp2/transport/chttp2_transport.cc\",\"file_line\":609,\"referenced_errors\":[{\"created\":\"@1567422907.350271639\",\"description\":\"Failed parsing HTTP/2\",\"file\":\"/home/ryan/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0-alpha.4/grpc/src/core/ext/transport/chttp2/transport/chttp2_transport.cc\",\"file_line\":2533,\"referenced_errors\":[{\"created\":\"@1567422907.350252230\",\"description\":\"Expected SETTINGS frame as the first frame, got frame type 80\",\"file\":\"/home/ryan/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0-alpha.4/grpc/src/core/ext/transport/chttp2/transport/parsing.cc\",\"file_line\":261},{\"created\":\"@1567422907.350268529\",\"description\":\"Trying to connect an http1.x server\",\"file\":\"/home/ryan/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0-alpha.4/grpc/src/core/ext/transport/chttp2/transport/chttp2_transport.cc\",\"file_line\":2489,\"grpc_status\":14,\"http_status\":400}]},{\"created\":\"@1567422907.350775263\",\"description\":\"OS Error\",\"errno\":32,\"fd\":6,\"file\":\"/home/ryan/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0-alpha.4/grpc/src/core/lib/iomgr/tcp_posix.cc\",\"file_line\":857,\"grpc_status\":14,\"os_error\":\"Broken pipe\",\"syscall\":\"sendmsg\",\"target_address\":\"ipv4:127.0.0.1:22379\"}]}"]

What is the type of the changes?

  • Bugfix

How is the PR tested?

Manually test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

continue to use openssl
Signed-off-by: Ryan Leung <rleungx@gmail.com>

@rleungx rleungx requested review from BusyJay and overvenus Sep 2, 2019

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

PTAL @BusyJay

@overvenus

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

This PR also fixes #5389.

@Connor1996
Copy link
Member

left a comment

LGTM

@rleungx rleungx added the S: CanMerge label Sep 6, 2019

@sre-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit d6e86c5 into tikv:master Sep 6, 2019

6 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.