Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: use new approximate keys function when result is 0 (#5403) #5414

Merged
merged 5 commits into from Sep 7, 2019

Conversation

@sre-bot
Copy link
Collaborator

commented Sep 6, 2019

cherry-pick #5403 to release-3.0


Signed-off-by: root you1474600@gmail.com

What have you changed?

Please explain in detail what the changes are in this PR and why they are needed:

  • Summarize your change
    When the new get_region_approximate_keys_cf function return 0, the get_region_approximate_keys function will downgrade to use the old get_range_entries_and_versions function. For this situation, 0 should be returned.

  • Describe any limitations of the current code (optional)
    Add a test but the the test also passed using old get_range_entries_and_versions function.

What is the type of the changes?

Pick one of the following and delete the others:

  • Bugfix (a change which fixes an issue)

How is the PR tested?

Add a test function raftstore::coprocessor::split_check::keys::tests::test_region_approximate_keys_sub_region.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

Refer to a related PR or issue link (optional)

#5306

you06 added 4 commits Sep 4, 2019
Signed-off-by: root <you1474600@gmail.com>
Signed-off-by: root <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@sre-bot

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

@hicqu
hicqu approved these changes Sep 6, 2019
Signed-off-by: root <you1474600@gmail.com>
@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=release-3.0

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=master

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/integration-compatibility-test /integration-ddl-test

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

/run-all-tests

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=master

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test

@H-ZeX

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

2 similar comments
@H-ZeX

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=pr/883

@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

1 similar comment
@you06

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2019

/run-integration-cop-push-down-test tidb-test=pr/883

@you06 you06 merged commit 304cc7d into tikv:release-3.0 Sep 7, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.