Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: use new approximate keys function when result is 0 (#5403) #5415

merged 4 commits into from Sep 6, 2019


Copy link

commented Sep 6, 2019

cherry-pick #5403 to release-2.1

Signed-off-by: root

What have you changed?

Please explain in detail what the changes are in this PR and why they are needed:

  • Summarize your change
    When the new get_region_approximate_keys_cf function return 0, the get_region_approximate_keys function will downgrade to use the old get_range_entries_and_versions function. For this situation, 0 should be returned.

  • Describe any limitations of the current code (optional)
    Add a test but the the test also passed using old get_range_entries_and_versions function.

What is the type of the changes?

Pick one of the following and delete the others:

  • Bugfix (a change which fixes an issue)

How is the PR tested?

Add a test function raftstore::coprocessor::split_check::keys::tests::test_region_approximate_keys_sub_region.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?


Does this PR affect tidb-ansible?


Refer to a related PR or issue link (optional)


you06 added 3 commits Sep 6, 2019
update cargo.lock
Signed-off-by: root <>
cherry pick 2.1
Signed-off-by: root <>
format code
Signed-off-by: root <>

@you06 you06 requested review from AndreMouche and Connor1996 Sep 6, 2019

Cargo.lock Outdated Show resolved Hide resolved
remove comment in Cargo.lock
Signed-off-by: you06 <>

@you06 you06 force-pushed the you06:approximate-keys-2.1 branch from 6acd89e to e13bdc2 Sep 6, 2019


This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019


Copy link

left a comment



This comment has been minimized.

Copy link

commented Sep 6, 2019


@sre-bot sre-bot merged commit c4aaa3e into tikv:release-2.1 Sep 6, 2019

5 checks passed

DCO All commits are signed off!
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
idc-jenkins-ci/test Jenkins job succeeded.
@overvenus overvenus referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.