Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract sst_importer #5438

Merged
merged 18 commits into from Sep 11, 2019

Conversation

@brson
Copy link
Contributor

brson commented Sep 9, 2019

What have you changed?

Extract most of the import module to the sst_importer crate, leaving only the ImportSSTService behind, which is still coupled to parts of the server.

This is part of extracting raftstore #5437, and a follow up to extracting keys #5376.

What is the type of the changes?

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?

cargo test, make clippy, make format

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

no

Does this PR affect tidb-ansible?

no

Refer to a related PR or issue link (optional)

#5437

Benchmark result if necessary (optional)

Any examples? (optional)

brson added 13 commits Aug 12, 2019
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
brson added 2 commits Sep 9, 2019
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Signed-off-by: Brian Anderson <andersrb@gmail.com>
@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Sep 10, 2019

@overvenus overvenus requested a review from kennytm Sep 10, 2019
Copy link
Contributor

kennytm left a comment

LGTM

@brson brson added the C: Build-Time label Sep 10, 2019
@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Sep 11, 2019

Copy link
Contributor

overvenus left a comment

👍

@kennytm kennytm added the S: CanMerge label Sep 11, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Sep 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit dbe8832 into tikv:master Sep 11, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Brian Anderson <andersrb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.