Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cargo run workflow #5439

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@Hoverbear
Copy link
Member

Hoverbear commented Sep 9, 2019

What have you changed?

Fixes #5289 by using Default-members and default-run as @brson suggested.

What is the type of the changes?

Pick one of the following and delete the others:

  • New feature (a change which adds functionality)
  • Improvement (a change which is an improvement to an existing feature)
  • Bugfix (a change which fixes an issue)
  • Engineering (engineering change which doesn't change any feature or fix any issue)
  • Misc (other changes)

How is the PR tested?

cargo run & CI

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

Nope

Does this PR affect tidb-ansible?

Nope

Refer to a related PR or issue link (optional)

#5289

Benchmark result if necessary (optional)

N/A

Any examples? (optional)

cargo run, cargo run --bin tikv-ctl

Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear Hoverbear requested review from brson and overvenus Sep 9, 2019
@Hoverbear Hoverbear self-assigned this Sep 9, 2019
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Copy link
Contributor

siddontang left a comment

LGTM

Copy link
Member

Connor1996 left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Sep 10, 2019

/run-all-tests

@Connor1996 Connor1996 removed the S: PTAL label Sep 10, 2019
@sre-bot sre-bot merged commit 1868b85 into tikv:master Sep 10, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.